Skip to content

Revert vector_search_endpoints UUID persistence (#5127, #5192)#5193

Merged
janniklasrose merged 3 commits into
mainfrom
janniklasrose/revert-vsendpoint-uuid-persist
May 6, 2026
Merged

Revert vector_search_endpoints UUID persistence (#5127, #5192)#5193
janniklasrose merged 3 commits into
mainfrom
janniklasrose/revert-vsendpoint-uuid-persist

Conversation

@janniklasrose
Copy link
Copy Markdown
Contributor

@janniklasrose janniklasrose commented May 6, 2026

Summary

Test plan

  • ./task build clean.
  • go test ./acceptance -run 'TestAccept/bundle/resources/vector_search_endpoints/drift' — all green (terraform + direct).
  • go test ./bundle/direct/dresources/... — green.
  • ./task lint-q — clean.
  • Verified post-deploy plan shows Plan: 0 to add, 0 to change, 0 to delete, 2 unchanged after an out-of-band endpoint recreate, so permissions don't end up in permanent drift even without UUID-based recreate detection.

This pull request and its description were written by Isaac.

…ter out-of-band recreate

Adds permissions to the recreated_same_name drift test and asserts that a
post-deploy plan shows no changes. Documents that without `endpoint_uuid`
in state, the bundle still converges: the first plan after the remote
recreate proposes creating permissions on the new endpoint (since state
remap returns the live UUID), and a second plan post-deploy shows no
permanent drift.

Co-authored-by: Isaac
@janniklasrose janniklasrose merged commit c6168a1 into main May 6, 2026
24 of 25 checks passed
@janniklasrose janniklasrose deleted the janniklasrose/revert-vsendpoint-uuid-persist branch May 6, 2026 15:01
janniklasrose added a commit that referenced this pull request May 18, 2026
Main reverted vector_search_endpoints UUID persistence in #5193, so
the endpoint plan no longer carries a synthetic endpoint_uuid change
to be classified as Skip via OverrideChangeDesc. Regenerate the
with_endpoint plan output to match.

Co-authored-by: Isaac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants